toSvg with wrapSignature cuts the signature

[alexgarbarev]

Hello and thank you for wonderful library!

I'd like to raise on minor problem I faced with. Sometimes, when I try to export signature toSvg using following params:

final control = HandSignatureControl();
...
HandSignature(
  control: control,
  width: 2.0,
  maxWidth: 5.0,
)
...      
final svg = control.toSvg(
  wrapSignature: true,
);

I see that the signature gets cutted. I guess it might be related to line width or something. Please see attached screenshots: Actual signature (inside HandSignature)

Exported to svg:

Another example of cropped signature (In svg format):

Thanks in advance for any advice :)

[ZdenekKrcal]

I have same problem, I always get cutted signature with option:

final svg = control.toSvg(
  wrapSignature: true,
);

[RomanBase]

Hey, wrapSignature has been redesigned to fit property to better correspond with properties of other export options. There was a problem with rescaling/filling data during export, so bounds of the signature are now extended with maxStrokeWidth to better fit visible dimensions.

Please check version 3.0.1.

[alexgarbarev]

Thanks @RomanBase it works much better now!

My only humble suggestion is: avoid breaking public API in one patch change (3.0.0 -> 3.0.1) in compliance of semantic versioning: https://semver.org/#spec-item-6. (see items 6 and 7). Instead we could add @deprecated annotation with suggestion to use new property instead. Then remove all deprecation in next major release. That way other developers can plan APIs upgrading.