search

RomanKubiak / ctrlr

Ctrlr
BSD 3-Clause "New" or "Revised" License
525 stars 61 forks source link

Switch from internal midi message comparison on input to native JUCE #131

Open RomanKubiak opened 3 years ago

RomanKubiak commented 3 years ago

Since now JUCE has all the possibilities to match MIDI messages (single and multi-message NRPN/RPN style), we can switch to using that, some of the nasty code that I implemented could be removed and based on something that's verified and known to work.

dobo365 commented 3 years ago

What do you mean by "possibilities to match MIDI messages"? Actually, even if nasty code (your words), I'm quite happy and don't face issues. Thus just be careful by just commenting the code before removing it or be prepared to un-commit changes) I would not prioritize this change but I can understand that from a maintenance perspective it would be better so of course I support it ;-)

Possemo commented 3 years ago

This does not work properly indeed. In most cases sliders do not react to incoming MIDI. Would be great if that would be fixed one day. But I guess JUCE does it only for standard CC's and NRPN/RPN but probably not for sysex. BTW. with the automation parameters of the plugin there is a workaround for this: Most DAW's can assign CC's to automation parameters. This way Ctrlr works as a controller converter. You can use a simple hardware controller which only supports CC to control synths with weird sysex or NRPN's.

Godlike-Productions commented 3 years ago

I'm not sure if this is related but versions later than 5.3.201 don't seem to support sending MIDI from LUA using sendMidiMessageNow() when the panel is saved as a restricted instance (ie VST or VST3). It works fine with the Ctrlr VST, but as soon as it is exported, all the MIDI stops.