Closed fluffy-critter closed 5 years ago
It looks like it's the result of change 06b99a9a7a3271e9c81c2b5e29fba4443a8facfb. @RomanSixty what was the rationale for that change? I believe SimplePie already decodes things as correctly as is possible to do, and any feed that's putting on an extra layer of entity encoding is just broken and unfixably so...
In any case I have made a change on my fork at https://github.com/fluffy-critter/Feed-on-Feeds/commit/e87e2fe6ea26e7cec39c03d6974866af8b39d765 which seems to work correctly on properly-formatted feeds. I'll submit a PR after I've tested it further to see what feeds I follow break.
Example item causing problems: https://beesbuzz.biz/blog/6128-Federated-identity-with-Atom-and-WebSub
In the feed, all of the content is included in a
CDATA
segment, and its entities are then further encoded correctly, e.g.:Unfortunately, something is decoding those
<
s et al, and so FeedOnFeeds (or maybe it's SimplePie) renders it as HTML, thus horking the layout of the rest of the entry:(Also it seems that
class
attributes aren't getting filtered out either, I could have sworn the existing sanitization was supposed to do that...)