search

Romanitho / Winget-AutoUpdate

WAU daily updates apps as system and notify connected users. (Allowlist and Blocklist support)
MIT License
1.19k stars 142 forks source link

check and fix log folder permissions #753

Open FaserF opened 1 month ago

FaserF commented 1 month ago

Proposed Changes

As described in #752 it wont work to write user logs since WAU2.0.0, this affected Winget-Install.ps1 runs within the user (seems to work for WAU user runs). We are now checking on every run, if the folder permissions are correctly set to allow "everyone" to do everything within the logs folder and if the permissions are missing, we are setting it.

Please let me know, if "Install-Prerequisites.ps1" is a good place to check this, or if we should move it somewhere to the WAU installation itself (dont know which file is responsible for this?).

Related Issues

752

ITistheworst commented 6 days ago

Worth noting that making folders under programfiles user-writable is not generally advisable as it can be used to circumvent application launch protections like AppLocker.

May make more sense to instead have this log sit in the user or programdata area.