search

Romanx / Cake.Coverlet

Coverlet extensions for Cake Build
MIT License
40 stars 15 forks source link

[WIP] Coverlet tool execution #10

Closed StanleyGoldman closed 5 years ago

StanleyGoldman commented 5 years ago

Fixes #7

At first I was just going to quickly rip what I implemented here: https://github.com/octokit/octokit.net/pull/1866

But then I ended up looking at decompiled sources of some methods and noticed how Cake handles calling dotnet tools so I quickly made a stub. I could use your help to finish filling it in as I'm pretty new to cake and coverlet.

I don't have the time to finish right now, but I'm just not sure about the arguments. I guess I'm just not sure If the functionality in CoverletAliases.ProcessArguments will be correct.

Also I'm using Cake.Frosting, so I just need the methods implemented. I believe you might have some scripts to test that you can adapt to testing as a dotnet tool.

Todo:

Reference material

https://github.com/cake-build/cake/blob/develop/src/Cake.Common/Tools/DotNetCore/DotNetCoreAliases.cs#L1043-L1057

https://github.com/cake-build/cake/blob/develop/src/Cake.Common/Tools/DotNetCore/VSTest/DotNetCoreVSTester.cs

https://github.com/cake-build/cake/blob/develop/src/Cake.Common/Tools/DotNetCore/VSTest/DotNetCoreVSTestSettings.cs

StanleyGoldman commented 5 years ago

@Romanx Take a look when you can, please feel free to push to the branch if you'd like.

Romanx commented 5 years ago

@StanleyGoldman Hi there. I think i've got this working but i'm unfortunately not able to push to your fork. Not sure why or how that works, not sure if you've got any idea? 😄

StanleyGoldman commented 5 years ago

Hey @Romanx, that's really weird. I have this checkbox ticked.

image

But go ahead, close this pull request and push a new branch to your own repo with my stuff. I'll find you there...

Romanx commented 5 years ago

@StanleyGoldman It's probably something i'm doing wrong. I'll open it here and open a PR and we'll continue the discussion. Thanks for your contribution up to now!

Romanx commented 5 years ago

Superseded by #10

StanleyGoldman commented 5 years ago

Superseded by #11 you mean..

Romanx commented 5 years ago

@StanleyGoldman yup indeed i do 😄