Implement PlantedTank Sensor and MarineTank Sensor that extends Basic Tank Model in the Sensor Microservice

[RomeoIndiaJulietUniform]

Issue: Implement PlantedTankService and MarineTankService

Description

We need to create two models, PlantedTank Sensor and MarineTank Sennsor , that will manage the functionalities specific to planted and marine tanks, respectively. Both services should implement the BasicTank Model interface to ensure consistency and shared functionalities across different tank types.

Parameters

• Basic Parameters:

  • Temperature
  • pH Levels
  • Light
  • Nitrate Sensor

• Planted Tank Parameters:

  • CO2 Sensor

• Marine Tank Parameters:

  • Salinity Sensor
  • Calcium Sensor
  • Alkalinity Sensor
  • Nitrite Sensor

Implement the PlantedTank class that:

• Implements the BasicTank Model interface.
• Provides specific functionality for managing planted tanks, including:
  • Managing the CO2 sensor.

Implement the MarineTank class that:

• Implements the BasicTank Model interface.
• Provides specific functionality for managing marine tanks, including:
  • Managing the salinity, calcium, alkalinity, and nitrite sensors.

Test Cases

• Create unit tests for PlantedTank that validate:

  • The ability to correctly add and retrieve CO2 sensor readings.
  • Proper monitoring of basic parameters (Temperature, pH Levels, Light, Nitrate).

• Create unit tests for MarineTank that validate:

  • The ability to correctly add and retrieve salinity, calcium, alkalinity, and nitrite sensor readings.
  • Proper monitoring of basic parameters (Temperature, pH Levels, Light, Nitrate).

Acceptance Criteria

• Both services should compile without errors.
• Each service should have its own unique functionalities while adhering to the methods defined in the BasicTankService interface.
• Unit tests should be created to validate the behavior of each service and should pass successfully.

Additional Notes

• Ensure proper documentation for each method and class.
• Follow the project's coding standards and conventions.

[LadislavTorma]

Hello @RomeoIndiaJulietUniform, I found this issue quite interesting will you please assign it to me?

[RomeoIndiaJulietUniform]

Hii @LadislavTorma , thanks a lot for showing interest in the project. I'm happy to inform you that I have assigned this issue to you. You can take reference from the Actuator Service , the logic is quite similar.

Happy Coding 🙂!

[LadislavTorma]

Hi @RomeoIndiaJulietUniform , Today, I finally found some time to work on the issue assigned to me: Implement PlantedTankService and MarineTankService. However, as I reviewed the code, it looks like the issue has already been resolved as of September 22nd. Could you please confirm if I understood this correctly? Or are there specific aspects of the issue that still need to be addressed that I may have missed?

I just want to make sure I’m not duplicating work or misunderstanding the requirements.

Looking forward to your clarification!

Thanks, @LadislavTorma

[RomeoIndiaJulietUniform]

@LadislavTorma thanks for the question, I think there is a issue with the clarity , I have reformated the issue section for better understanding.

So, the project needs seperate sensor service for marine tank and planted tank as biological paramteres are different, you can refer the Actuator Microservice it already implements seperate Actuator while having a parent Basic Aquarium model (https://github.com/RomeoIndiaJulietUniform/AquaManage_Backend/tree/main/ActuatorService/src/main/java/com/DragonFish/aquaManage/ActuatorService/Models)

For more understanding you can refer this Excali Draw link (https://t.co/NTjHOfdP3j) . Pls feel free to ask if you have any more doubt , I am happy to help !!!