n0toose
commented
1 year ago P.S. I also reproduced the same results with flake8, I need some feedback as to whether I should start fixing each issue that flake8 throws at me by hand before merging, or if that should be done with a new set of changes.
P.S.S. It's normally a "bad practice" to indiscriminately modify code in the way that I did, as it essentially ruins git blame, but, eh, in this context, I do not really care that much. However, this is part of the reason why I am wondering whether I should author a new commit for the things I change "by hand".
isort, yapf and black were used.
My motivation for this pull request is that our entire backlog of pull requests was dealt with, which is very helpful if you'd like to refactor massive amounts of code -- this should also fix a regression that I accidentally introduced which basically causes all of our CI builds to fail. It should be obvious that this change doesn't/should not contain any functional changes. I trust black's defaults, so I did not try to change them in any way. I did not test the changes locally yet.
I would like an initial first look. Please do not merge this yet, as I'd like also like to break some of the comments that use many, many columns in this commit into multiple lines.