Romern / syncMyMoodle

Synchronization client for RWTH Moodle
GNU General Public License v3.0
73 stars 18 forks source link

AttributeError: 'NoneType' object has no attribute 'split' #105

Open marcluque opened 1 year ago

marcluque commented 1 year ago

I encountered this error for the master branch at da13ec10292e5de1dff81dfa834f4a81df335ccd. Using python 3.10 on Ubuntu 22.04.2

  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "~/__main__.py", line 1251, in <module>
    main()
  File "~/__main__.py", line 1245, in main
    smm.sync()
  File "~/__main__.py", line 736, in sync
    self.root_node.remove_children_nameclashes()
  File "~/__main__.py", line 161, in remove_children_nameclashes
    child.remove_children_nameclashes()
  File "~/__main__.py", line 161, in remove_children_nameclashes
    child.remove_children_nameclashes()
  File "~/__main__.py", line 161, in remove_children_nameclashes
    child.remove_children_nameclashes()
  File "~/__main__.py", line 113, in remove_children_nameclashes
    s.name = f"{s.name}_{s.url.split('/')[-1]}"
AttributeError: 'NoneType' object has no attribute 'split'
n0toose commented 1 year ago

Could you please provide some additional information as to what you were trying to do at the time -- or send a more --verbose log (make sure to hide any information you don't want the public to see)?

marcluque commented 1 year ago

Could you please provide some additional information as to what you were trying to do at the time -- or send a more --verbose log (make sure to hide any information you don't want the public to see)?

The verbose logging produced a lot of output, is there some sensitive data being logged? I just want to make sure that I can dump the log here. I couldn't find any of my sensitive data while grepping the log.

fabianunterstell commented 1 year ago

I can reproduce the error. Syncmymoodle installed with pip in Version 0.1.0 on WSL Ubuntu 22.04.3 LTS inside Windows 10 Education.

Used command:

python3 -m syncmymoodle --verbose --courses https://moodle.rwth-aachen.de/course/view.php\?id\=23424 >> log.txt 2>&1

This is the config.json used, and the log.txt returned. I removed sensitive data from both files.

Setting "opencast": true, and "folder": true was the minimal configuration I could trigger the error with while trying different config options but this was by no means an extensive probing.