search

Romern / syncMyMoodle

Synchronization client for RWTH Moodle
GNU General Public License v3.0
72 stars 18 forks source link

Improve Sciebo downloads #117

Open nilshee opened 5 months ago

nilshee commented 5 months ago

solves #110

D-VR commented 1 month ago

What is the status of this? Anything left open or are we good to go?

nilshee commented 1 month ago

There are still a couple of bugs, I haven't had the time to fix.

Also, naming the folders for the Sciebo downloads needs a solution. Maybe the Section headers in Moodle as folder names (if folder-share). Currently, the trailing hash of the link is used as folder name.

nilshee commented 1 month ago

Also, some lecturers put the same Sciebo link on multiple sites cf. Post-quantum cryptography. I'm not sure how to handle that. Are relative symlinks an option or should we drop duplicates with a warning?

Also, in the same Moodle room, there is a sciebo link for the videos folder and direct links to the videos.

Does anyone have ideas on how to solve these problems? Or will we download everything multiple times?

septatrix commented 1 month ago

For now it should be finde to do the native approach and download them multiple times. Improving it can be done in a separate PR. Automatically detecting those cases it probably a bit more annoying to get right.

D-VR commented 1 month ago

For now it should be finde to do the native approach and download them multiple times. Improving it can be done in a separate PR. Automatically detecting those cases it probably a bit more annoying to get right.

there's also issues with link finding in general, even in the current search it will try out the same link multiple times. I had started looking into it, but didn't have the time to do anything. So yeah duplication is fine for now