search

Romern / syncMyMoodle

Synchronization client for RWTH Moodle
GNU General Public License v3.0
71 stars 18 forks source link

Downloading videos from rwth.video/video.fsmpi.rwth-aachen.de fails if login is required #31

Open CryptKid opened 3 years ago

CryptKid commented 3 years ago

SyncMyMoodle discovers links to video.fsmpi.rwth-aachen.de and tries to download them but if the video requires login it downloads the 403 forbidden page instead of logging in and downloading the video (I.e. https://video.fsmpi.rwth-aachen.de/19ws-ds/15150 leads to https://video.fsmpi.rwth-aachen.de/files/pub/19ws-ds/19ws-ds-191015-720p.mp4 and then downloads a 403 forbidden page) I would suggest to continue to try to download without auth but to check if http status 403 is returned and in that case sign in before retrying

septatrix commented 2 years ago

A simple workaround until the proper authentication flow is implemented would be to run smm while you are connected to the RWTH VPN.

n0toose commented 1 year ago

Been nearly a year since this issue was opened -- is it safe to assume that this works as intended?

septatrix commented 1 year ago

No not really. It should either log a warning and not download it (by checking the return code for 403) or try to login (which is more annoying to implement).

However, I do not deem this a high priority as using the VPN is a easy workaround.