search

Romern / syncMyMoodle

Synchronization client for RWTH Moodle
GNU General Public License v3.0
72 stars 18 forks source link

Some video files are being skipped #45

Closed ghost closed 3 years ago

ghost commented 3 years ago

Since last update, I'm missing some of the videos. I couldn't identify a pattern tho But it affects 'plain' Moodle videos without this puzzle icon

ghost commented 3 years ago

As it can be seen, from 19 video files, only 13 are downloaded

image

Romern commented 3 years ago

its likely that the filenames might be identical, i.e. zoom_0.mp4. If yes, then someone would need to fix https://github.com/Romern/syncMyMoodle/issues/35 , and/or use the name from moodle as a new filename (Folien 1-5: Inhalt und Kapitel 1.1.mp4)

Romern commented 3 years ago

Could you try https://github.com/Romern/syncMyMoodle/commit/ea17a29d741d5fca17f6175aeef5305bf4ce482e ?

ghost commented 3 years ago

Looks good to me. All files are named after the moodle title, right?

septatrix commented 3 years ago

Looks good to me. All files are named after the moodle title, right?

A bit simplified but in most cases yes. There are some exceptions though. Among them is special handling for name clashed which might be the root cause of you problem and should have been resolved since the linked commit.

So is this issue still present or can this be closed?

ghost commented 3 years ago

Yes indeed, this can be closed. Thanks