search

Romern / syncMyMoodle

Synchronization client for RWTH Moodle
GNU General Public License v3.0
73 stars 18 forks source link

Added h5p interactive video support #98

Closed Gameheld closed 2 years ago

Gameheld commented 2 years ago

Added support for the new moodle function with interactive video functionality. See here: https://docs.moodle.org/400/en/H5P_activity

septatrix commented 2 years ago

Also H5P do not have to be an <iframe> though the code currently makes this assumption

Gameheld commented 2 years ago

@septatrix Do you have an example Moodle Room with h5p and without iframes? Mine are all with iframes

septatrix commented 2 years ago

No, I just happen to know that it is part of the H5P standard and Moodle supports it

Gameheld commented 2 years ago

So I did something. The code now checks for iframes. Also, I changed the scanforlinks method in a way so that the h5p youtube links are added properly. I didnt really see the need to check for single there, because we use findAll anyways. I changed the else-case, because in my opinion it basically did the same. Tested the code with some courses that had h5p integrations aswell as normal youtube links. Everything worked as expected. Please tell me if I missed something.