RonasIT / laravel-swagger

Laravel-Swagger is a fully automate tool which allows to generate and save swagger-based documentation after successful completing your application's feature tests.

https://ronasit.com

MIT License

143 stars 42 forks source link

#78: Added new PhpUnit extension and event subscriber to support PhpUnit v10 and deleted redundant PushDocumentation artisan command #79

Closed vitgrams closed 10 months ago

vitgrams commented 1 year ago

…

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

vitgrams commented 1 year ago

@DenTray Implemented for phpUnit v 10. These changes will break backward compatibility. Could you please review this code?

vitgrams commented 1 year ago

@DenTray Resolved review conversations.

DenTray commented 1 year ago

@vitgrams could you please cover new code by test cases

vitgrams commented 1 year ago

@DenTray Increased code coverage by unit tests. I can't write test method for PhpUnit extension class because notify() method has mandatory event argument which is the object of the final class.

vitgrams commented 1 year ago

@DenTray Please note that the changes from 78_save_temp_doc_in_file_for_local_and_storage_drivers branch have been merged into current branch because rebase operation is not allowed here.

DenTray commented 1 year ago

@vitgrams could you please resolve conflicts