Rongronggg9 / RSS-to-Telegram-Bot

A Telegram RSS bot that cares about your reading experience
https://t.me/RSStT_Bot
GNU Affero General Public License v3.0
1.51k stars 276 forks source link

the `feed_deactivated_warn` is not sent to the `ERROR_LOGGING_CHAT` #550

Open hellodword opened 6 days ago

hellodword commented 6 days ago

It looks like the feed_deactivated_warn message is always being sent to the user who subscribed to the feed, but if I set the ERROR_LOGGING_CHAT, I would expect that chat to receive all error messages.

https://github.com/Rongronggg9/RSS-to-Telegram-Bot/blob/5a675703b3a59ef8eb1b46cf647986075591905b/src/monitor/_notifier.py#L220-L271

Rongronggg9 commented 6 days ago

This is intended, or else users, except for those in ERROR_LOGGING_CHAT, would never know their subscriptions had been paused (deactivated).

By design, ERROR_LOGGING_CHAT is for severe unexpected errors. These errors usually need to be fixed eventually.

However, I do plan to allow the administrators of channels or groups to redirect these deactivation messages to somewhere else.

Rongronggg9 commented 6 days ago

However, I do plan to allow the administrators of channels or groups to redirect these deactivation messages to somewhere else.

In theory, ordinary users can also utilize such a feature. 🤔

I am super occupied these days and I have not started working on it yet. I would appreciate it if you would like to implement it.

hellodword commented 6 days ago

This is intended, or else users, except for those in ERROR_LOGGING_CHAT, would never know their subscriptions had been paused (deactivated).

Here is my use case: I've created several channels for users and manage the bot through direct chat with it. As the admin, I just set up the feeds for the channels and fix issues when errors occur, but I don't care about the content of the feeds. Similarly, the users don’t care about the error messages or which feeds the channels are subscribed to.

I am super occupied these days and I have not started working on it yet. I would appreciate it if you would like to implement it.

I'd love to, but such a highly engineered Python project is difficult for me. I will try, but it may not succeed.