search

RonnyDo / ColorPicker

A color picker for elementaryOS.
GNU General Public License v3.0
107 stars 28 forks source link

The app is not showing in workplace overview #28

Open WebShapedBiz opened 7 years ago

WebShapedBiz commented 7 years ago

In Workspace overview (⌘ + S) the app does not show. It's not at the bottom in icon box nor it's visible on current workplace. It is however visible in windows overview, both ⌘ + A and ⌘ + W

Screencast: https://www.useloom.com/share/d7204d4a336d46adad30ce4f89109c29

RonnyDo commented 6 years ago

Hi WebShapedBiz thanks for sharing the issue and sorry for the late reply.

Your right it's not shown. The reason is that the ColorPicker window is inherited from Gtk.Dialog (see https://github.com/RonnyDo/ColorPicker/blob/master/src/ColorPickerWindow.vala#L24). Gtk.Dialogs aren't shown in the Workspace overview.

By changing the parent class from Gtk.Dialog to Gtk.Window this issue would be fixed. However some more adaptations need to be done in this case.

If you have a simpler solution, let me know (or even make a pull request). Otherwise you have to wait until the next release ;-)

PS: Apps like danrabbits Nimbus are based on Gtk.Window as well and suffer from the same problem (https://github.com/danrabbit/nimbus).

WebShapedBiz commented 6 years ago

Thank you very much @RonnyDo for your time and effort.

Cheers.