search

RonnyDo / ColorPicker

A color picker for elementaryOS.
GNU General Public License v3.0
107 stars 28 forks source link

Allow editing the color string to specify the color. #35

Closed elpete closed 4 years ago

elpete commented 6 years ago

Hi! I'm brand new to both elementary OS and Vala, so this pull request may be rubbish. I'd love any pointers you may have as well.

I thought I'd try to tackle allowing a user to specify the color as a string and then displaying it in the app and the history. This is done by allowing the user to edit the entry and parsing the color when the user presses enter. If the value is a valid color, the color will be parsed and used. If not, the action is ignored.

Here's an animated gif of the feature:

ezgif com-crop

I noticed #30 while typing up this pull request. I totally understand if you want to implement this a different way. I'd be happy to try my hand at that as well (with some mentoring, if you can).

Thanks for an awesome project and a chance to learn Vala, GTK, and elementary OS!

RonnyDo commented 6 years ago

Hi elpete, I feel absolutely sorry for the unforgivable late reply! Thank you so much, this is a very good feature you describe here. Actually I‘m working on v2.0 of the color which solves several open issues. I have to check if your code fits into the new workflow of the picker. But I’m sure your lines will make it somehow into the new version.

Best regards and enjoy the elementary way of life 🖖