RonnySteady / dogpass

Dog Pass is my Capstone Project for the neuefische WebDeveloper Bootcamp.
https://dogpass.vercel.app
1 stars 0 forks source link

User Story 2: Add dog form #2

Open RonnySteady opened 1 year ago

RonnySteady commented 1 year ago

Value Proposition

As a dog owner, I want to be able to add a new dog so that I can expand my dog list with new dogs

Description

image

Acceptance Criteria

Tasks

FelineHuhn commented 1 year ago

Hey Ronald, from now on, please post your user stories in the user-stories channel, so that everyone can give you a review. 😊

I have some suggestions for you: I think your user story should better be the adding of a new dog instead of only the add button, since the button has no function without a form to add a dog. Please adjust this to your whole user story and than post it again.

FelineHuhn commented 1 year ago

Hey Ronald, great work! 🎉 I have some tiny suggestions for you:

I think you forgot to update your value proposition, or? It better should be written something like: As a dog owner I want to be able to add a new dog so that I can expand my dog list with new dogs

I ask me, if your form is placed on another page (than you should mention that in your acceptance criteria and tasks) or below your "Add another dog" button)?

Also I would maybe call the button only "Add Dog", because if you expect to create a DogPass for your first dog later on, it shouldn't say "another", should it? And you also should create an input field of the dog's name and better give the form another general headline (at least if it is located on another page).

Your acceptance criteria and tasks could be more specific in general, some examples:

Acceptance criteria

Tasks

FelineHuhn commented 1 year ago

As I see your user story is already in review, but one tiny thing i forgot about: You should give the input label for "Name:" also a so the user knows, it's also required like the other input fields with a , or? 😊 And also in some input labels you have ":" behind the label-word an sometimes not. I would say you could choose one way, to make it more consistent, or?

MariaRiosNavarro commented 1 year ago

LGFM 🚀

RonnySteady commented 1 year ago

Thanks Maria!
Thank you Feline, I just made the labels consistent.