search

Rookiestyle / GlobalSearch

Enhance KeePass search functionality to search in all open databases
GNU General Public License v3.0
29 stars 4 forks source link

doesn't play well with KeeResize #20

Closed TBugReporter closed 3 months ago

TBugReporter commented 3 months ago

Overview

With KeeResize and GlobalSearch both installed, the Find window is slightly off in terms of size. (See image here.)

Context

OS: Win11 KeePass Version: 2.57 Plugin Version: 1.31

TBugReporter commented 3 months ago

It's getting worse...

Original: Screenshot 2024-06-19 010823 Latest: Screenshot 2024-07-04 035209 (Also note that nothing I do brings your added option or the bottom buttons into full view; I have to cope with just a sliver of the checkbox showing - or use the Tab key to move to it and Space to toggle it.)

Rookiestyle commented 3 months ago

Try the attached debug build.

It was pretty complex to deal all 3 cases

GlobalSearch.zip

TBugReporter commented 3 months ago

Your new version seems to always add 100 to the window height, regardless of whether it needs it or not - the first time I did Ctrl-F, the new section was nicely framed in the window (despite it being larger than necessary), but the second time the window grew again, unnecessarily.

Rookiestyle commented 3 months ago

"second time" = Closing and opening the search window again? Does it grow bigger everytime or only the second time and then sticks to this new size?

Please try the new version, I once again changed it a bit and added some info messages GlobalSearch.zip

TBugReporter commented 3 months ago

Closing and opening the search window again?

Yes.

Does it grow bigger everytime [...] ?

Yes.

After manually shrinking to fit the screen: Screenshot 2024-07-06 221049 After close and immediate reopen: Screenshot 2024-07-06 221141 Those were with 1.3.1.1; this next one is 1.3.1.2: Screenshot 2024-07-06 224643 And yes, KeeResize is still installed.

TBugReporter commented 3 months ago

After "OK": Screenshot 2024-07-06 230739

Rookiestyle commented 3 months ago

One more try... This version 1.3.1.3 comes with different adjustments and active debug mode.

If it works, an "OK" is sufficient, I'll publish a new release then - without active debug flag If it does not work, please attach the created debug file. GlobalSearch.zip

TBugReporter commented 3 months ago

Size is now stable, but search itself crashes. It works - I get results, but only after "Continue"ing from an unhandled exception. Screenshot 2024-07-08 020848 BTW, is the checkbox supposed to clear between every search? Debug_GlobalSearch_20240708T055544Z.xml.txt

Rookiestyle commented 3 months ago

The checkbox will remember its previous state. This did not happen as concequence of the uncaught exception.

The newly released version 1.3.2 contains the KeeResize adjustment and the fix of this exception