RoootTheFox / Linux-MegaHack-Installer

Helper script to install MegaHack v6/v7/v8 on Linux
GNU General Public License v3.0
39 stars 11 forks source link

(fatal) Could not find the file you specified! #19

Closed LounaCodes closed 5 months ago

LounaCodes commented 5 months ago

I'm on Arch Linux, I installed the requirements and provided the exact path to the "MegaHackInstaller8.zip" archive. It will just give me this error: (fatal) Could not find the file you specified! and then close. I have a pretty minimal install, are you sure, there aren't any other dependencies I could be missing here?

LounaCodes commented 5 months ago

[FIXED] looking through the script, fzf is required to detect the zip file correctly. Please add as a dependency next to unzip or warn user upon running the script

RoootTheFox commented 5 months ago

fzf shouldn't be required at all! - its optional, if you can't proceed without fzf, that is a bug.

RoootTheFox commented 5 months ago

this block of code should handle the case where fzf isn't installed - in that case, it'll just fall back to using read -r to query the path from the user. is it possible that you dragged the file in your terminal and/or the path had file:// at the beginning?

LounaCodes commented 5 months ago

No, I just used a normal path. It was in my downloads directory, but that shouldn't matter. I tried both with and without quotation marks. The path format was like this: /home/user/Downloads/MegaHackInstaller8.zip

RoootTheFox commented 5 months ago

hm, that shouldn't break - can you add printf "-%s-" "$megahack_zip right below the read line (and temporarily remove fzf) and show me what it outputs?

LounaCodes commented 5 months ago

Hey, sorry for the long wait, but I reinstalled my system in the meantime and I'm somehow not able to replicate the issue... Also I didn't reclone the directory or any files at all, so I really don't know what's going on.

RoootTheFox commented 5 months ago

there was probably some sort of whitespace or escape character that somehow ended up in the path entry. good to know that it was likely not a bug though ^^ thanks for reporting either way!!