search

RoootTheFox / custom-gamemode-colors

a geometry dash mod that allows setting color overrides per gamemode
3 stars 1 forks source link

ship/ufo mini cube override incompat with QOLMod #7

Open v1ct1m-v opened 4 months ago

v1ct1m-v commented 4 months ago

So, it claims in the icon that the cube and ship colors are WAY different from eachother, however, when i tried it, the cube always has the same colors as the ship, all i want you to do is fix the thing.

RoootTheFox commented 4 months ago

in the color popup of the mod (icon kit) you can configure the colors for each gamemode individually, did you do that?

if yes, what platform are you on? (windows, mac, android32, android64)

v1ct1m-v commented 4 months ago

Well, i am on andriod32.

I am sorry for replying so late.

On Sun, Mar 31, 2024, 2:26 PM rooot @.***> wrote:

in the color popup of the mod (icon kit) you can configure the colors for each gamemode individually, did you do that?

if yes, what platform are you on? (windows, mac, android32, android64)

— Reply to this email directly, view it on GitHub https://github.com/RoootTheFox/custom-gamemode-colors/issues/7#issuecomment-2028573234, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHMYIWZTVQMQWOZEQDTMTMLY26UCDAVCNFSM6AAAAABFMGQJAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGU3TGMRTGQ . You are receiving this because you authored the thread.Message ID: @.***>

RoootTheFox commented 4 months ago

make sure both cube and ship are enabled - else the mod will not override either of them

RoootTheFox commented 3 months ago

update: this seems to be an incompatibility with QOLMod (cc @TheSillyDoggo - how are you modifying icon colors, specifically m_iconSprite and m_iconSpriteSecondary?)

TheSillyDoggo commented 3 months ago

Meow :3 (I set the colours in GJBaseGameLayer::update so uhh)

RoootTheFox commented 3 months ago

Meow :3 (I set the colours in GJBaseGameLayer::update so uhh)

@TheSillyDoggo that explains - i'm only setting the colors when the gamemode changes. are you setting m_iconSprite/m_iconSpriteSecondary colors differently than the others? since the rest seems to work just fine

TheSillyDoggo commented 3 months ago

Nope I just do the normal gd setColor

RoootTheFox commented 3 months ago

is there any way to tell QOLMod to not call setColor every frame? or would I have to hook update and call setColor there? (i would like to avoid that for performance reasons)

RoootTheFox commented 3 months ago

i did NOT mean to close the issue github

TheSillyDoggo commented 3 months ago

I kinda have to set the colours in update because RGB and pastel but I'll add a thing to make it not set colours