Fix PIN size according to the right maximum value

RoopeHakulinen / cordova-plugin-mifare-ultralight

Cordova plugin for interacting with Mifare Ultralight NFC tags.

MIT License

9 stars 3 forks source link

Fix PIN size according to the right maximum value #9

Closed lonk closed 5 years ago

lonk commented 5 years ago

Fixes #7

RoopeHakulinen commented 5 years ago

Just to confirm one final thing @lonk: this is not a breaking change, right? So the existing usage of unlocking will work okay the way I see it? The usage is from JS only and there you only have the number type anyways.

lonk commented 5 years ago

It doesn't change the way unlocking was previously working ! The only change is that it doesn't throw an error anymore if the PIN is higher than 0x7FFFFFFF, and it truncates the PIN if it's higher than 0xFFFFFFFF (as an example: 0xAABBCCDDEE will try to unlock the tag with the pin 0xBBCCDDEE)

RoopeHakulinen commented 5 years ago

Excellent. I'll try to publish a new version soon.