fix: react16 support, close #14

Root-App / react-native-mock-render

a fork of react-native-mock that renders

MIT License

85 stars 50 forks source link

fix: react16 support, close #14 #15

Closed silentcloud closed 7 years ago

bob-carson commented 7 years ago

Thanks for opening this PR @silentcloud. React 16 support is important to us, but we have chosen to tackle that upgrade at the same time as the upgrade to Enzyme 3.0. We've started this conversion, but the work you have done here will be helpful to include. These fixes should be merged and published in the coming weeks.

I really appreciate your interest in contributing and I hope you continue to participate in this project both through feedback and contributions moving forward!

AaronFriel commented 7 years ago

This is a blocking issue for downstream projects wanting to update their own tests to target React 16. Since React.PropTypes was deprecated for months with warnings to users of React, could this please be merged and published? Theprop-types` package is backwards compatible with React 15, so there is no reason not to.

jimmy-devine commented 7 years ago

I'm working on releasing a beta in the next day or two. The spirit of this PR will be included in the changes. Closing this for that new PR. I'll post a link when it's up.