search

Root-App / react-native-mock-render

a fork of react-native-mock that renders
MIT License
85 stars 50 forks source link

Remove ART #89

Closed sonicdoe closed 2 years ago

sonicdoe commented 4 years ago

ART has been removed in React Native v0.62. See https://github.com/facebook/react-native/commit/9a0ebe0abaec7b59bdefe63cd7d392737ab20160 and @react-native-community/art. Fixes #47.

caroaguilar commented 4 years ago

@root-devs @lelandrichardson Is there a chance this PR can be merged and get a new npm release soon? React Native 0.63 is out as well and this package is an important part of our suite of testing and we need to migrate to latest RN. I'd really appreciate if we can this out! 🙏

leonardoprangetw commented 4 years ago

approve please

fabioxd20 commented 4 years ago

@root-devs @lelandrichardson can you approve this ? 🙏

igoriols commented 4 years ago

Hi @root-devs @lelandrichardson , we are working to migrate our react-native version to 0.63.2. The approval of this PR is crucial to our migration. Can you approve this, please?

jakequade commented 4 years ago

@root-devs @lelandrichardson What's stopping this from being merged?

AnyIdeasAds commented 4 years ago

anyone? Approve?

dochsu commented 3 years ago

Can this change be merged to allow us to migration to react-native version 0.63.2? We currently have our tests disabled to allow our CI to pass. Not optimal but our tests are legacy and will require some effort to rewrite.

sjransom commented 3 years ago

@root-devs @kukiron Is there a reason this can't be merged currently?

mrdulin commented 3 years ago

I folked this fixed commit and published to my own npm registry.

https://www.npmjs.com/package/dl-react-native-mock-render

Why published to npm registry instead of installing from github? Because I met this issue https://github.com/yarnpkg/yarn/issues/7212 at CI phrase of github action

dac245 commented 10 months ago

I folked this fixed commit and published to my own npm registry.

https://www.npmjs.com/package/dl-react-native-mock-render

Why published to npm registry instead of installing from github? Because I met this issue yarnpkg/yarn#7212 at CI phrase of github action

I tried using this but seems like the repo is not there anymore. Is there a different repo?