search

RootSoft / walletconnect-dart-sdk

Open protocol for connecting dApps to mobile wallets with QR code scanning or deep linking.
MIT License
102 stars 61 forks source link

Feature/ethereum support #18

Closed 3ph closed 2 years ago

3ph commented 2 years ago

@RootSoft I've added a new provider with basic Ethereum methods. I had to reorganise the code a bit as the abstract provider doesn't fit Ethereum methods. This seems to be similar to what other implementations do. Feel free to change that or suggest a different approach.

I would also update the README once we confirm the final implementation.

RootSoft commented 2 years ago

Thanks for the Pull Request @3ph ! Tested it out using metamask and got Ropsten working as well. There's indeed not a 1-on-1 mapping between the different providers.

I've made some changes at the providers side:

Can you Allow edits from maintainers. so I can push the commit to your PR for review? You can also check the branch here: https://github.com/RootSoft/walletconnect-dart-sdk/tree/ethereum

Please review it as well and let me know if there could be any improvements.

jlalvarez18 commented 2 years ago

@3ph allow edits so we can get this going!! :)

3ph commented 2 years ago

Hey @RootSoft. Sorry I was away. "Allow edits from maintainers" is already enabled though.

I'll check out the branch tomorrow when I get a bit more organised.

3ph commented 2 years ago

@RootSoft Checked out your branch, looks good! Are you able to push the commit here or do you want to merge your branch?

RootSoft commented 2 years ago

@3ph I've merged my branch with yours. Another discord user is also testing it out later this week. If no additional comments are made, I will publish a new version at the end of this week.

akshay-bhimani-pedalsup commented 2 years ago

Any example for signing transactions for Ethereum? I am not able to find can you share it here.

Also, do you have a discord server? I will be happy to join and support the community.