search

Roozenboom / rbnx

Nx plugin for WebdriverIO support
https://www.npmjs.com/package/@rbnx/webdriverio
MIT License
10 stars 1 forks source link

fix: use wdio configPath relative from workspace root to run wdio #14

Closed Roozenboom closed 1 year ago

Roozenboom commented 1 year ago

Current Behavior

When the e2e executor is used it runs wdio with a generated config file. This file is stored in the root of the e2e project and is referenced only by the file name. We create a child process to run wdio and configure the working directory (cwd) to the e2e project. With NPM this worked as expected, but when the project is using yarn as a package manager the working directory is not set correctly, resulting in an error Could not execute "run" due to missing configuration file

Expected Behavior

This PR changed how we configure the generated configuration in the child process command. Instead of the file name we use the file path relative to the workspace root. We also update the import path for the base configuration to always be relative to the generated config location.

Related Issue(s)

Fixes #13

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 28acfaa4b20e096138a1f0258b10267cc5bee615. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 4 targets - [`nx affected --target=test --parallel=3 --ci --code-coverage`](https://cloud.nx.app/runs/arpPTpxMnI) - [`nx affected --target=lint --parallel=3`](https://cloud.nx.app/runs/df2tpD5zCe) - [`nx affected --target=build --parallel=3`](https://cloud.nx.app/runs/6Nn2VUMWdH) - [`nx-cloud record -- npx nx format:check`](https://cloud.nx.app/runs/hRpFOwp8KR)

Sent with 💌 from NxCloud.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.5.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: