Ropecon / wp-kompassi-integration

Integrate Kompassi data to your WordPress instance
Other
1 stars 0 forks source link

When showing the location of an event, please use the value of the `location` GraphQL attribute instead of the location dimension #68

Closed japsu closed 1 day ago

japsu commented 2 days ago

The attached program in hitpoint2024 has two values in the room dimension: Lautapelialue and Lautapelialue, aktiviteettinurkka.

The Kompassi backend now knows it should omit Lautapelialue if it is included in Lautapelialue, aktiviteettinurkka when determining the value for the location attribute.

Furthermore, there may be a freeform override or additional specifier in the location attribute in the future. The location attribute always contains what the program manager intended to be displayed independently of the values of the room dimension.

The guide, however, would seem to be manually combining room dimension value titles with ", ". Can you switch to using the location attribute of ScheduleItem instead?

NB: A deprecated location attribute is provided in Program, but it is not recommended to be used in any new things. See https://github.com/con2/kompassi/blob/aa7f3e70108c07febc3319406d44a2154ea75fe9/backend/program_v2/graphql/program_limited.py#L36-L45

image
japsu commented 2 days ago

This is how it shows up in V2 Light: https://v2.kompassi.eu/hitpoint2024/program

image