search

RoryChenXY / DataRepExp_public

A shiny app that was developed to improve the FAIR of research data hosted on data repository.
MIT License
2 stars 1 forks source link

Miscellaneous #6

Open pydemull opened 3 weeks ago

pydemull commented 3 weeks ago
  1. In the section “Overview/Data Visualisation Tool for Data Repositories”, there is a problem with ‘Chen et al. [citation]’. The citation is missing.
  2. In the file https://github.com/RoryChenXY/DataRepExp_public/blob/main/dataprep/dataprep.R; you load several packages twice because you load the tidyverse collection and also you load single packages that are components of the tidyverse collection: dplyr, tidyr, forcats, magrittr. This is not very efficient and could be updated (eg, by loading only the required packages and not all the collection of tidyverse packages. Because magrittr is a dependency imported in the environment when loading dplyr, it might not be necessary to explicitly load it.
  3. Typo in the README: “Deatail Notes”. (Deployment Notes, bullet 1).
  4. In the Data Preparation section (https://github.com/RoryChenXY/DataRepExp_public/blob/golem/notes/1_dataprep.md) , it would be nice to explain that at the end, the user should have an RData file containing a list of the data frames required so that the app works, correct?
  5. About a comment in the Documentation: Not R skill only is required to modify the app but also an intermediate level in Shiny.
  6. It would be nice that the csv files exported have a name that describe more specifically their content.
  7. In the visualization tab (Metadata), graphics are nice. Would it possible to make sure that metadata that appear on the bar plots can all be viewed in the box when we have the cursor on the graphic.
  8. The README file should be updated so that it exactly corresponds to the content of the app (cf. screenshots). This remarks concern at least the online app.
  9. It would be nice to have some documentation to explain how to install the app locally (eg with RStudio).