search

Rosa-Luxemburgstiftung-Berlin / ansible-opnsense

Ansible role to configure OPNsense firewalls
18 stars 8 forks source link

Add tasks to clean unconfigured P2s #67

Closed Jonybat closed 5 months ago

Jonybat commented 5 months ago

https://github.com/Rosa-Luxemburgstiftung-Berlin/ansible-opnsense/issues/21

The expected result is that after the P2 configuration loop loop IPSec ike phase2 for ikeid {{ ikeid }}, it will search for all P2s present in config file for the respective ikeid, and then remove the ones that are not present in the host variables, based on uniqid

We have already used these 2 tasks in our prod env successfully. Unfortunately, i dont have the time atm to look into building tests for this.

zerwes commented 5 months ago

Hello @Jonybat Thank you for your PR We where aware of the issue #21 but had no time on our side to take care of this ... So I think I can implement the tests on our side.

zerwes commented 5 months ago

Hello @Jonybat I have implemented the test in #72 After merging your PR they succeed (as expected) Thank you for your PR