search

Rosa-Luxemburgstiftung-Berlin / ansible-opnsense

Ansible role to configure OPNsense firewalls
18 stars 8 forks source link

gw fixes for new versions + gw/route handler #83

Closed zerwes closed 3 months ago

zerwes commented 3 months ago

closes #78 closes #70

zerwes commented 3 months ago

Hello @mnaier

No, this is safe, as exactly this is the topic of the PR: change the code from the legacy xml path /opnsense/gateways/gateway_item to the new xpath /opnsense/OPNsense/Gateways/gateway_item and the task in question cleans up the legacy path.

Please use the PR to comment your review https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews

Best place would be inline in the corresponding code lines in the files changed tab (https://github.com/Rosa-Luxemburgstiftung-Berlin/ansible-opnsense/pull/83/files)

On Thu, 2024-07-25 at 05:28 -0700, Mohammad Mustafa Naier wrote:

@mnaier commented on this pull request. In tasks/gateways.yml:

@@ -32,30 +48,75 @@  # - descr: WAN gateway group  #   +# see issue #70 +- name: remove legacy gateway_items

  • delegate_to: localhost
  • community.general.xml:
  • path: "{{ local_config_path }}"
  • xpath: "/opnsense/gateways/gateway_item" probably the path is not changed? xpath: /opnsense/OPNsense/Gateways/gateway_item[not(node())] — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.Message ID: <Rosa- Luxemburgstiftung-Berlin/ansible- @.***>