Code review

[igarrido-adalab]

Really cool job @RosaBF !!!

Here you have some tips to improve the exercise:

JavaScript: basic

• [x] Define the logic to make the counter work.
• [x] Check if the number is less than 1 or greater than 100.
• [x] Remember that every time we use .innerHTML or .value to get DOM content we receive a string. Sometimes we will need to use something like parseInt() to convert it to a number. https://github.com/Adalab/modulo-2-evaluacion-intermedia-RosaBF/blob/67e4225ade2401ff714166f7d28b250826070205/js/main.js#L23
• [x] If we repeat several times parseInt(value) within a function it is better set it in a constant.

JavaScript: advanced

• [x] Move the feedback logic to a function and execute it on each click.
• [x] Move you counter logic into a function and execute it on each click.
• [x] Remember to use oneaddEventListener for each event. If you need to execute multiple functions at once perhaps you can call them inside your unique handler.
• [ ] You are writing many times "trackEl.innerHTML = 'something';", what about making a function that accepts a string as param and paints it into 'trackEl'?

JavaScript: good practices

• [x] Move variables and constants declarations to the top of the file. https://github.com/Adalab/modulo-2-evaluacion-intermedia-RosaBF/blob/67e4225ade2401ff714166f7d28b250826070205/js/main.js#L13-L19

Good practices

• [x] Try to improve your commits messages. "Add JS" is a bit poor. "Add random number logic" is more explanatory.

HTML

• [x] Use placeholder attribute instead of value one to show a field's hint.

Steps to finish the game (for those far from the solution)

You are close to the exercise solution, but here you have a steps guide to complete it anyway ;)

1. Init counter of trials to 0.
2. Define a function that executes when the user clicks on the button, that

• increments the counter and paints its value in the HTML when the user clicks the test button.

5. Assign a listener to the button click to execute both functions.

Further challenges

Then you can improve the game as you please, here you have some ideas:

• Add new feedback when the number is bigger than 100 or smaller than 0.
• Manage when the user hits the button and the input is empty.
• Make the input work when hitting enter key.
• Add a reset button that cleans the input, the counter, writes the initial feedback and generates a new random number to play again!
• Whatever you want!

Call to action

Let me know if you have any doubts ;)

Go for it!!

Do not close this issue until your teacher asks you to

[RosaBF]

Hi Ivan,

All changes are done except this one:

"You are writing many times "trackEl.innerHTML = 'something';", what about making a function that accepts a string as param and paints it into 'trackEl'?"

I have written to you a Slack message with this issue. Unfortunately I am a bit stuck with it. I f you could give me a hand I'd really appreciate it.

Thank you very much for all the comments.