[ISSUE] RMG can't load zipped files that contains a rom with non-english characters in its file name

ElektroStudios commented 6 months ago

Steps to reproduce the bug

Pick any rom file and rename it adding a character from Windows-1252 (latin) character set, for example: Pokemon Snap.n64 -> Pokémon Snap.n64. (the e character was renamed to é)
Compress the rom file to generate a zip file, and try to load the zip file in RMG by dragging the file or by using the menu to load it.
At this point RMG will stop responding, it will hang and it will kill itself after some seconds.

Observations

The file name of the zip file it does not matter, you can name it as test.zip, the problem is with the characters in the file name of the compressed rom file (Pokémon Snap.n64) inside the zip, not with the characters of the .zip file name.
The renamed rom file (Pokémon Snap.n64) can be loaded successfully. The problem is only when the rom file it is contained inside a zip file, regardless of the file name of the .zip file, I insist.
I've tried this with very few roms in n64 format, and I did very few tests but I think they were enough to get to all these conclusions.

Environment

RMG v0.5.4-1-gdbca218
Windows 10 x64

Rosalie241 commented 6 months ago

Currently, that's a limitation of the zip library I'm using and windows itself, so unless I switch to a different library to extract zip archives which supports wchar_t* for filenames in zip files on windows, this cannot be solved, this should work fine already on linux though.

ElektroStudios commented 6 months ago

It is not a problem of urgent necessity, but it is a kinda compatibility issue that is currently present, it can affect various zipped roms whose official titles / file names in Spanish are written with accented vowels, and I wanted to expose the problem in case of that you were not aware of it.

By the way, I discovered RMG today and it is beautiful, I prefer it than the other ones, great job!.

Rosalie241 / RMG