search

Rosalie241 / RMG

Rosalie's Mupen GUI
GNU General Public License v3.0
572 stars 50 forks source link

cmake: support GNUInstallDirs #216

Closed orbea closed 5 months ago

orbea commented 5 months ago

This is helpful for distros which may not use the default install paths, for example some Linux distros expect lib64 instead of lib on x86_64 while others do not.

Reference: https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

Rosalie241 commented 5 months ago

Thank you for the patch, however it reminded me that I already had the same patch in one of my branches: https://github.com/Rosalie241/RMG/commits/install-fixes/, it also needs some additional changes to RMG-Core and the ci's appimage generation so I'll try to merge that branch instead!

I appreciate the PR though :heart:

orbea commented 5 months ago

Sounds good to me, thanks.