search

Rosalie241 / RMG

Rosalie's Mupen GUI
GNU General Public License v3.0
572 stars 50 forks source link

cmake: Set OPTFLAGS for mupen64plus plugins #217

Closed orbea closed 5 months ago

orbea commented 5 months ago

Uses the CFLAGS set for the cmake build rather than the default OPTFLAGS in the mupen64plus Makefiles.

This is useful on source based distros like Gentoo which wants to respect the CFLAGS/CXXFLAGS set by the user which matches what the rest of the cmake build is already doing.

Rosalie241 commented 5 months ago

Thank you for the patch, but your patch doesn't account for an empty CMAKE_C_FLAGS, so I've pushed https://github.com/Rosalie241/RMG/commit/0afc565bda66338747ccf31b17610a35e9ae4343 to master which takes that into account (and also the USE_LTO option when it's empty), I really appreciate you trying to help out so I apologize for closing all the PRs!

orbea commented 5 months ago

I really appreciate you trying to help out so I apologize for closing all the PRs!

No problem, thanks for the help and sorry for getting off on the wrong foot earlier. Its easy to create unintentional misunderstandings with text and my main motive is providing some kind of mupen frontend with parallel for Gentoo and your frontend seems like the best choice.

Rosalie241 commented 5 months ago

Its easy to create unintentional misunderstandings with text

Yes for sure, and sorry for my behavior too!

my main motive is providing some kind of mupen frontend with parallel for Gentoo and your frontend seems like the best choice.

I'm glad you like it so much :heart: