search

Rosalie241 / RMG

Rosalie's Mupen GUI
GNU General Public License v3.0
572 stars 50 forks source link

Revert "3rdParty: update mupen64plus-video-GLideN64" #218

Closed orbea closed 5 months ago

orbea commented 5 months ago

This reverts commit 1111e94e176cf5b9311a9762a2839f3e1b659aca.

This commit broke the GLideN64 install with RelWithDebInfo which is default in Gentoo.

Additionally this was fixed previously in commit 31584044083699ce55cf29c9e0b63bcb93b28a2a.

Rosalie241 commented 5 months ago

I think this is incorrect, it should be fixed in the 3rdparty's cmakelists.txt instead because else gliden64 will have debugging things enabled which is undesired (i.e we only want debug info, we dont want opengl debug things)

Rosalie241 commented 5 months ago

pushed a commit to master which fixes this the way I've described, thank you for the PR though!

orbea commented 5 months ago

Indeed your fix did help, thanks!