search

Rosalie241 / RMG

Rosalie's Mupen GUI
GNU General Public License v3.0
637 stars 52 forks source link

Add About Dialog #28

Closed JakobDev closed 2 years ago

JakobDev commented 2 years ago

I added just a little about dialog. You may want to modify Config.hpp-in so it takes the tag name (without the leading v) instead of changing it per hand every update.

grafik

JakobDev commented 2 years ago

The requested changes are now done. I also disabled resizing of the About Window.

But to be honest, I think showing the latest commit in the About Dialog is a bad idea. Is a version released as version 0.1.1, this is what should be shown in the About Dialog rather than the latest commit.

Rosalie241 commented 2 years ago

The requested changes are now done. I also disabled resizing of the About Window.

I'd prefer to keep resizing an option, so please revert that.

But to be honest, I think showing the latest commit in the About Dialog is a bad idea. Is a version released as version 0.1.1, this is what should be shown in the About Dialog rather than the latest commit.

I'll change GIT_VERSION to use git describe --tags --always now, so on version v0.1.2 it'll be v0.1.2 then

JakobDev commented 2 years ago

Resizing is now enabled again, but it looks ugly when maximized.

Rosalie241 commented 2 years ago

Thank you very much :heart: