Rosalie241 / RMG

Rosalie's Mupen GUI
GNU General Public License v3.0
611 stars 52 forks source link

CachedRomHeaderAndSettings.cpp lacks an `#include <algorithm>` #42

Closed CounterPillow closed 2 years ago

CounterPillow commented 2 years ago
/home/fratti/Projekte/RMG/Source/RMG-Core/CachedRomHeaderAndSettings.cpp: In function ‘std::vector<l_CacheEntry>::iterator get_cache_entry_iter(std::string, bool)’:
/home/fratti/Projekte/RMG/Source/RMG-Core/CachedRomHeaderAndSettings.cpp:77:17: error: ‘find_if’ is not a member of ‘std’; did you mean ‘find’?
   77 |     return std::find_if(l_CacheEntries.begin(), l_CacheEntries.end(), predicate);
      |                 ^~~~~~~
      |                 find

resolved by adding #include <algorithm> to the file. Probably specific to the STL version, something used to pull it in and no longer does or something like that.

Rosalie241 commented 2 years ago

Fixed with https://github.com/Rosalie241/RMG/commit/ae2d70256039c6569b01c3115799b1f9bc14c0b5, thanks for reporting it :heart: