Rosalie241 / RMG

Rosalie's Mupen GUI
GNU General Public License v3.0
611 stars 52 forks source link

The settings of Angrylion RDP Plus doesn't function/do anything in v0.2.5 of RMG #73

Closed RokkumanX closed 1 year ago

RokkumanX commented 1 year ago

Hello Rosalie!

I'm really loving RMG to it's fullest but I have stumbled upon a weird bug where I'm unable to change settings with Angrylion RDP Plus in RMG v0.2.5 Well technically you can change settings but they don't get applied at all, they are saved however as they match the ones in the mupen64plus.cfg file but they do nothing.

If I were to exchange the Angrylion RDP Plus plugin from RMG v0.2.5 with an older one from let's say RMG v0.1.9 (which is the oldest one I got) all my saved settings from the GUI/mupen64plus.cfg works immediately but the only caveat is that you are no longer able to customize the settings from the UI but only through tweaking the mupen64plus.cfg file.

Also as a side-note, ParaLLEl is totally unaffected by any of this. Everything works as intended as far as changing settings go in both GUI and mupen64plus.cfg.

A very big thank you in advance! ❤️

GhostlyDark commented 1 year ago

Can't reproduce this using RMG v0.2.5. It loads and saves settings and Angrylion-Plus respects those settings just fine (Win10). What operating system are you using?

RokkumanX commented 1 year ago

I'm using Windows 10 Enterprise LTSB 21H2.

Yes it loads and saves the settings but the image quality doesn't change, it seems to always output Filtered + Hybrid even if I change it to Unfiltered + Bilinear which I always use.

If I set it to Depth you would notice the difference immediately, that's why the Angrylion RDP Plus plugin from v0.1.9 works the way it should.

This is how it works for me:

  1. I use the v0.2.5 package plugin
  2. I change the default Filtered + Hybrid to Unfiltered + Bilinear from either the GUI or the mupen64plus.cfg
  3. I restart the emulator, load a game and nothing have changed image wise, still Filtered + Hybrid quality despite the change
  4. I exchange the v0.2.5 plugin with the 0.1.9 plugin and the image outputs proper Unfiltered + Bilinear image quality

Not much else to say about it really, but if no one else have the same problem I can live with using the v0.1.9 plugin and change settings manually in the mupen64plus.cfg

GhostlyDark commented 1 year ago

I see. I made some mistakes introducing the GUI. I pointed it out to Rosalie, so it should get fixed soonish. https://github.com/Rosalie241/angrylion-rdp-plus/blob/RMG/src/plugin/mupen64plus/gfx_m64p.cpp#L212-L218

RokkumanX commented 1 year ago

Thank you very much, looking forward to the fix!

Rosalie241 commented 1 year ago

I've fixed it, will be included in the next release, but sadly that'll take a little while due to a UI overhaul I'm working on

RokkumanX commented 1 year ago

Anything you are working on is worth the wait, keep shining!

Rosalie241 commented 1 year ago

Fixed in v0.2.6! :two_hearts:

RokkumanX commented 1 year ago

Thanks Rosalie, it works great now!