search

Rosalie241 / RMG

Rosalie's Mupen GUI
GNU General Public License v3.0
611 stars 52 forks source link

Issues with command line startup zip archives with East Asian filenames #87

Closed crashGG closed 1 year ago

crashGG commented 1 year ago

Platform / OS : win10 x64

Github hash: newest

Issue: Start the zip with East Asian filenames at the command line, it doesn't work.for example: RMG.exe "罪与罚.zip"

show this error:

2023-01-20_182154

but start the .z64 with East Asian filenames at the command line, it works fine.for example: RMG.exe "罪与罚.z64"

Rosalie241 commented 1 year ago

This is a limitation of 1) the win32 char type (it only supports ANSI, while wchar_t would support UTF-8), i.e linux is sane in this regard and supports UTF-8 in char 2) minizip, the library I use to extract zip archives, due to it not exposing an API to open a filename using wchar_t

I'm not planning to switch to a different zip extraction library anytime soon but it should work fine on i.e linux.

Rosalie241 commented 1 year ago

Actually, after re-reading the documentation, I think I can fix this issue!

Rosalie241 commented 1 year ago

I've resolved the issue and cannot reproduce it locally anymore, can you try https://github.com/Rosalie241/RMG/actions/runs/3975236435 to see if it's been fixed for you aswell? :heart:

crashGG commented 1 year ago

yes , it has been fixed. test with g3c0698d

Rosalie241 commented 1 year ago

Thank you, the fix will be included in the next release then!

Thanks for reporting & testing, and I apologize for my initial reaction :heart:

crashGG commented 1 year ago

Thank you, the fix will be included in the next release then!

Thanks for reporting & testing, and I apologize for my initial reaction ❤️

RMG is the best N64 emulator, and you are the best.

Rosalie241 commented 1 year ago

The fix has been included in v0.3.0, thanks for the report! :heart: