RosepadMC / Rosepad

Custom Lilypad QA server&client
GNU General Public License v3.0
23 stars 10 forks source link

[RFC] Expose vanilla classes #50

Closed Vladg24YT closed 1 year ago

Vladg24YT commented 1 year ago

Overview

In current Rosepad toolkit (tested on commit 331d4b5), the classes get obfuscated upon build which doesn't allow direct calls to Vanilla classes.

Motivation

It is a common practice (in other modloaders) for the modders to make direct calls to Vanilla classes instead of creating their own APIs and implementation on top of the modloader.

the rest of RFC

A possible solution would be a creation of an automated script for setting up the MDK (Mod Development Kit) environment, where the sources are unobfuscated. Forge and Fabric do this when a user attempts to import their workspace into an IDE (see ForgeGradle and Loom respectively).

There are two things such a change would allow if it were to happen:

5GameMaker commented 1 year ago

Rosepad does not obfuscate classes (image: running unzip -l client/build/libs/client-1.1-SNAPSHOT-all.jar | grep .class) image commit: 331d4b5

Obfuscation utility was removed in 81e7ab5

Vladg24YT commented 1 year ago

My bad, I used RosepadClient.jar as a dependency instead of the minecraft.jar from rosepad_versions, closing the issue.