Quark Causes Cascading Worldgen in The Midnight

Rosethorns / CUTSAshes

end of 1.12.2 era remake of the 1.7.10 CUTSpack

0 stars 0 forks source link

Quark Causes Cascading Worldgen in The Midnight #19

Open Rosethorns opened 4 years ago

Rosethorns commented 4 years ago

I have had a look at the quark config and as far as I can tell, any worldgen that Quark is doing is restricted via whitelist to particular dimensions. 0 (overworld), 1 (nether) and -1 (the end) So I can't see why quark is getting involved in Midnight worldgen at all. Yet the log yells about it

noobanidus commented 4 years ago

Are cave roots dimension-limited?

legendblade commented 4 years ago

~~See Vazkii/Quark#1252~~ which is unrelated, as varied dungeons are limited to the overworld, in theory.

Rosethorns commented 4 years ago

cave roots are restricted in the config to dim 0 (overworld) same with varied dungeons. doing a spectator fly around in The Midnight I have not found any signs of Quark generation

winnetrie83 commented 4 years ago

I also noticed cascading worldgen lagg. This is a very bad thing and should be a high priority to fix. It is commonly recommended to remove any mod from your game that causes cascading worldgen lagg. The cause of this issue is because the mod is trying to generate something outside of a loaded chunk wich forces the chunk to load and if the same problems persists in that chunk the issue repeats it. Cascading thus.

noobanidus commented 4 years ago

Cascading chunk lag is an issue when it persistently and continuously cascades. If it's happening once or twice during generation, it's honestly not too big of an issue. If you're getting massive cascades then it can be problematic.

legendblade commented 4 years ago

Now that we have a firm grasp on the obvious... there are still two issues here:

Quark is potentially generating something in the Midnight when it shouldn't
It's doing so in a way that has potential to cause a significant cascade, whether by itself, or together with another mod that "wasn't to big of an issue" by itself.

I agree this isn't a high priority, but it is still an issue.