jueseph
commented
1 year ago Yes, you're right, there is a typo in the comment. It seems there is an equals sign where a minus/hyphen should be.
On Tue, Dec 6, 2022 at 11:24 AM zack @.***> wrote:
Looking at how the code works, seems like -1 is to turn off, not 1. That's unless I'm understanding the code wrong (which is possible!).
— Reply to this email directly, view it on GitHub https://github.com/RosettaCommons/RFDesign/issues/42, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABCU5YMTIPXOTXSDOBUXPDWL6HIJANCNFSM6AAAAAASV4YMPE . You are receiving this because you are subscribed to this thread.Message ID: @.***>
https://github.com/RosettaCommons/RFDesign/blob/bba6992283de63faba6ff727bb4bc68327a5356c/hallucination/hallucinate.py#L109
https://github.com/RosettaCommons/RFDesign/blob/bba6992283de63faba6ff727bb4bc68327a5356c/hallucination/loss.py#L680
Looking at how the code works, seems like -1 is to turn off, not 1. That's unless I'm understanding the code wrong (which is possible!).