Closed ctcisar closed 4 years ago
Updating this to add, I got binder to compile by removing "PRIVATE" in CMakeLists.txt:
@@ -35,7 +35,7 @@ add_clang_executable(binder
)
target_link_libraries(binder
- PRIVATE
+
clangTooling
clangBasic
clangASTMatchers
I cannot confirm whether this worked or not; I am still trying to get my bindings to compile with g++ and I don't know whether the errors I am facing are due to a bug in the project or because Binder did not generate the .cpp files properly.
(The included tests failed to run, because it failed to find clang++ to compile and verify the bindings.)
Thank you for letting me know @ctcisar ! Looks like this a regression from recent LLVM9 merge, i will looks this up.
@ctcisar i just pushed the patch, - when you have a minute could you please try see if that fix this issue for you? Thanks,
I am getting a similar error.
The keyword signature for target_link_libraries has already been used with
the target "binder". All uses of target_link_libraries with a target must
be either all-keyword or all-plain.
The uses of the keyword signature are here:
* cmake/modules/LLVM-Config.cmake:105 (target_link_libraries)
* cmake/modules/AddLLVM.cmake:771 (target_link_libraries)
I guess PRIVATE
in target_link_libraries
has already been removed because I dont see that at binder/source/CMakeLists.txt
.
Steps to reproduce
1) clone branch master
2) python build.py
Can someone please help me with this. Thank you.
@shiveshkhaitan i think this was addressed in https://github.com/RosettaCommons/binder/pull/95
I was still getting the error. I am not sure why but changing add_clang_executable
to add_executable
worked.
diff --git a/source/CMakeLists.txt b/source/CMakeLists.txt
index e867665..52564cb 100644
--- a/source/CMakeLists.txt
+++ b/source/CMakeLists.txt
@@ -5,7 +5,7 @@
set(LLVM_LINK_COMPONENTS support)
set(LLVM_USED_LIBS clangTooling clangBasic clangAST)
-add_clang_executable(binder
+add_executable(binder
binder.cpp
binder.hpp
Hi @shiveshkhaitan , what OS, compiller and LLVM version do you use?
Ubuntu 18.04.2 g++ 7.3.0 llvm 6.0
@shiveshkhaitan what about CMake version? Could you please post output of cmake --version
?
cmake version 3.10.2
I have been unable to build bind, even when using the provided scripts. I have installed clang and ninja through apt-get. System info:
This is the output I get from the script: