search

RosettaCommons / rosetta

The Rosetta Bio-macromolecule modeling package.
https://www.rosettacommons.org
Other
118 stars 56 forks source link

Adjust the git submodule paths for Forking potential. #3

Closed roccomoretti closed 8 months ago

roccomoretti commented 8 months ago

We use relative paths for many of the RosettaCommons submodules, to allow for https/ssh flexibility. However, for the open repository if someone were working off a fork, they wouldn't be able to get the submodules unless they also forked the submodule.

To fix that, we can be explicit about the RosettaCommons organization in the submodule URL.

This PR also updates the tools repo and (most of) the benchmark tests to use the main branch instead of the master branch.

roccomoretti commented 8 months ago

Not touched are the Benchmark release.py script and the observers files.

lyskov commented 7 months ago

@roccomoretti looks like this PR broke clean rebuild, particularly modules url = ../../RosettaCommons/libzmq.git could no longer be cloned...

roccomoretti commented 7 months ago

This looks to be due to the convert_submodule_urls_from_ssh_to_https() method on the test server. (https://github.com/RosettaCommons/rosetta/blob/main/tests/benchmark/tests/__init__.py#L1105)

lyskov commented 7 months ago

fix https://github.com/RosettaCommons/rosetta/pull/6