rename torch extras and defines

RosettaCommons / rosetta

The Rosetta Bio-macromolecule modeling package.

https://www.rosettacommons.org

Other

116 stars 55 forks source link

rename torch extras and defines #43

Closed lyskov closed 5 months ago

lyskov commented 5 months ago

Current Rosetta pytorch and pytorch_gpu extras are misnomers since we do link to libtorch and not to pytorch. This PR address this.

roccomoretti commented 5 months ago

One concern here would be the documentation and publication issues -- Is there a clear path for people who have used extras=pytorch and who are running scripts which explicitly reference rosetta_scripts.pytorch.linuxgccrelease going to be able to easily discover why those commands are no longer working?

lyskov commented 5 months ago

@MoritzErtelt this is now merged, could you please update the relevant docs? Thanks,

MoritzErtelt commented 5 months ago

Sure, I've updated the documentation 👍