RosettaCommons / rosetta

The Rosetta Bio-macromolecule modeling package.
https://www.rosettacommons.org
Other
154 stars 63 forks source link

fix(DAlphaBall make): Avoid duplicate symbols linker error #46

Closed rebelot closed 5 months ago

rebelot commented 6 months ago

Declare-only gmp globals in header file and define them in only one source file

rebelot commented 6 months ago

@rebelot Could you please sign the Rosetta Contributor Licensing Agreement at https://www.rosettacommons.org/forms/cla ? (See https://github.com/RosettaCommons/rosetta/blob/main/CONTRIBUTING.md for more info.)

signed 👌

ajasja commented 5 months ago

@roccomoretti Who are the people with the magic merge powers? I think we should aim to have as little open PRs as possible...

roccomoretti commented 5 months ago

They're the @can_merge_to_main team. (And should be able to be pinged as such.)

Agreed that we want to minimize the number of open PRs. This one unfortunately slipped through the cracks. (Sorry @rebelot.)