search

RosettaCommons / rosetta

The Rosetta Bio-macromolecule modeling package.
https://www.rosettacommons.org
Other
116 stars 55 forks source link

fixing util file names #57

Closed NooraAz closed 3 months ago

NooraAz commented 4 months ago

The argument passed to --class_name will be used as the prefix of util files.

roccomoretti commented 4 months ago

This would change the current default behavior for the util files, right? (What happens if you run the script for util without --class_name specified?)

I'm wondering if there's a way you can keep the current behavior with the command lines which currently work, but add in support for the additional behavior if you add in additional options.

vmullig commented 4 months ago

I'm wondering if there's a way you can keep the current behavior with the command lines which currently work, but add in support for the additional behavior if you add in additional options.

Since the old behaviour was counter-intuitive (the class name attribute was used to set the file name in all cases except making utility files, and this resulted in util.hh and util.cc being overwritten), I think replacing this with the new behaviour is fine -- especially since this isn't something that came up frequently, and a developer using this functionality is bound to run the generate_templates.py script with --help first. Noora has added a clear description to the --help output about what the new behaviour is. This looks pretty good to me.

roccomoretti commented 1 month ago

I'll note this PR broke the code_template_tests_src integration test, specifically for the issue mentioned above (the test runs without --class_name: https://b3.graylab.jhu.edu/test/829260)