RosettaDrone / rosettadrone

MAVlink and H.264 Video for DJI drones
BSD 3-Clause "New" or "Revised" License
308 stars 117 forks source link

Dependency problem WebRTC and mapbox #221

Closed utn-blei closed 2 months ago

utn-blei commented 2 months ago

Describe the bug

Hello, thanks for the great project! Buildin the app unfortunately results in the bug, shown above. Any idea how to fix it? Greeting!

Steps To Reproduce

  1. Clone Repository
  2. Adjust jdk versions
  3. Hit "Build Project"

Screenshots

image

Drone Model

DJI Air 3

Smartphone Model

- Model: emulator
- Android version:

Additional context

No response

kripper commented 2 months ago

@angel-ayala can you please take a look?

angel-ayala commented 2 months ago

I actually didn't test it in a emulator, but I don't know how the UI could be related. Additionally, the error says that no package was found in any repo. I have the exact gradle config from master if no diff could be a connection issue, maybe?

Adjust jdk versions

Just to be sure @utn-blei, the adjustement were those in #172 right? which OS are you using?

kripper commented 2 months ago

RD only works on specific architectures, because it depends on the DJI SDK.

utn-blei commented 2 months ago

Thanks for the quick reply!

Here is my workflow:

To the best of my knowledge, the probelm should not be related to the emulator. Right?

image

angel-ayala commented 2 months ago

there are a few post indicating the emulator thing

utn-blei commented 2 months ago

Thanks :) I cant even generate any .apk though since it fails much earlier in the process. I can therefore also not test on my mobile device.

How would you recommend building the project?

utn-blei commented 2 months ago

Seems like others face the same issue - at least regarding mapbox: https://github.com/RosettaDrone/rosettadrone/issues/172#issuecomment-2295017779

In case anyone runs into the same issue:

Creating an API token and adding it to the build as described below fixed the mapbox problem. https://stackoverflow.com/questions/68934036/could-not-find-com-mapbox-mapboxsdkmapbox-android-accounts0-7-0-on-fresh-inst

HEEJUN-SHIN commented 2 months ago

hello, @utn-blei. I faced the same problem regarding the mapbox and webrtc-google.

Does the https://stackoverflow.com/questions/68934036/could-not-find-com-mapbox-mapboxsdkmapbox-android-accounts0-7-0-on-fresh-inst help the mapbox problem? Should I put the API key inside the password?

I found out the problem comes from 'com.dji:dji-uxsdk:4.16', so I temporally added exclude group: 'com.mapbox.mapboxsdk', module: 'mapbox-android-accounts' below the implementation and It could be built successfully.

HEEJUN-SHIN commented 2 months ago

Also, the "Could not find org.webrtc:google-webrtc:1.0.32006" error, it seems like there are no actual file in the maven repository.

so I tried to look for webrtc-sdk in google repository, and found https://github.com/webrtc-sdk/android

using implementation 'io.github.webrtc-sdk:android:125.6422.05' instead of implementation 'org.webrtc:google-webrtc:1.0.32006' seems resolving the issue.

But I think there should be more changes on the settings.

yblei commented 2 months ago

Yes, adding the mapbox token resolved the issues. I followed the official guid on webboxes wesite though.

Regarding webrtc: I picked an earlier commit before it was integrated to build the app.

yblei commented 2 months ago

Also, the "Could not find org.webrtc:google-webrtc:1.0.32006" error, it seems like there are no actual file in the maven repository.

so I tried to look for webrtc-sdk in google repository, and found https://github.com/webrtc-sdk/android

using implementation 'io.github.webrtc-sdk:android:125.6422.05' instead of implementation 'org.webrtc:google-webrtc:1.0.32006' seems resolving the issue.

But I think there should be more changes on the settings.

Great!! Thanks for sharing.

kripper commented 2 months ago

Please provide a pull request. Thanks.