search

Rosettea / Hilbish

🌓 The Moon-powered shell! A comfy and extensible shell for Lua fans! 🌺 ✨
https://rosettea.github.io/Hilbish/
MIT License
496 stars 21 forks source link

fix(readline): flickering on line refresh #288

Closed TorchedSammy closed 4 months ago

TorchedSammy commented 4 months ago

closes #285

sleeptightAnsiC commented 4 months ago

https://github.com/Rosettea/Hilbish/issues/285 is still occuring on my side after the patch, see for reference: https://github.com/Rosettea/Hilbish/issues/285#issuecomment-2050556611

sleeptightAnsiC commented 4 months ago

I can see a huge difference on https://github.com/Rosettea/Hilbish/pull/288/commits/9cc032f3cbd8c3283e7c8430d975d88bf33ba206 https://github.com/Rosettea/Hilbish/issues/285 might not be relevant anymore but current behavior still isn't perfect - discord message for reference

https://github.com/Rosettea/Hilbish/assets/91839286/ac1039b1-4729-4fe6-8860-6a7af354b942

sleeptightAnsiC commented 4 months ago

https://github.com/Rosettea/Hilbish/pull/288/commits/512f96edb53da478492e335ad9fdab50a0b4f99f - text blinking is fully gone in getty. I can still notice cursor appearing on the beginning/end of current/next line. No video this time as it would look pretty much the same as the one from my previous comment. https://discord.com/channels/732357621503229962/732357622216392767/1229805577660661800