Rosettea / Hilbish

🌓 The Moon-powered shell! A comfy and extensible shell for Lua fans! 🌺 ✨
https://rosettea.github.io/Hilbish/
MIT License
496 stars 21 forks source link

Defining highlighter doesn't work on master #289

Closed jdugan6240 closed 4 months ago

jdugan6240 commented 4 months ago

Since commit 5b8471802175b416b948262178bb5f7b496a7772, which merged your line flickering fixes, it appears that defining a highlighter no longer works. I tried the following example from the docs:

--This code will highlight all double quoted strings in green.
function hilbish.highlighter(line)
   return line:gsub('"%w+"', function(c) return lunacolors.green(c) end)
end

Looking at the commit diff, it appears to me that the culprit lies in the changes to the hilbishLoad function in api.go, where the ability to set hilbish.highlighter and hilbish.hinter was removed.

TorchedSammy commented 4 months ago

The regression was caused by #287

jdugan6240 commented 4 months ago

Yeah, that did it. Thanks!