Rosewood-Development / PlayerParticles

The PlayerParticles plugin made by Esophose
Other
172 stars 49 forks source link

Make 'Save New Group' GUI button not require a chat message #64

Closed JasonHorkles closed 3 years ago

JasonHorkles commented 3 years ago

My server's chat is handled by Bungee, so sending a message doesn't register when using the 'Save New Group' GUI button. It would be cool if this would instead open up an Anvil GUI or something to set the name there so there aren't any conflicts

Esophose commented 3 years ago

Duplicate of #49 I'm trying to avoid having to rely on any sort of anvil gui since it requires version dependent code. The best way around it is to just use /pp group save <name>, I suppose there could be a setting to disable the functionality of the GUI button. I'm open to suggestions.

I'm a little confused why inputting a chat message would cause a problem. Is it because you have another chat plugin on the bungee end that is cancelling the message or something?

JasonHorkles commented 3 years ago

You could have it send a chat message or something when clicked saying "Click here to save a new group" and clicking it would autofill the /pp group save <groupName> command, or just a way to disable clicking the item in general so it just shows text explaining what to do

Yeah the bungee plugin cancels the chat from being sent to the server itself - I could set it to also pass the message to the server but then it'll have double messages

JasonHorkles commented 3 years ago

atm I have it do this image and image when clicked

Esophose commented 3 years ago

I really like the solution with the clickable text to copy a command to the chat input box. I'll add a setting for that in a day or two, if I forget please just respond here or ping me on discord and I'll get on it.

JasonHorkles commented 3 years ago

Sounds good, thanks so much!!

Esophose commented 3 years ago

This has been added and will be in the v7.17 release.